Repository navigation
Conversation
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds
no_stdsupport, so the crate can be used from a wasm runtime, plus two smaller changes that no_std consumers need.Why
Substrate runtimes compile to
wasm32-unknown-unknownwithoutstd. Everything here is available incoreandalloc.Changes
stdfeature,allocused wherestdwas assumedBitListaDefaultimpl to matchBitVectorBitVectoralready had one, the asymmetry is awkward for derived containerscorepaths from the derivesstd::paths, so it did not compile in a no_std consumer even when this crate itself didThe derive change is the one that matters most for downstream users. A no_std crate could depend on this one successfully and still fail to build the moment it used
#[derive(Encode)].Why it cannot build yet
This depends on
ethereum_serde_utilswith featurestd, and the published 0.8.1 has no such feature: it is added by #21. Until that releases, cargo cannot resolve.Verification
Verified locally against the proposed
ethereum_serde_utilsbranch via a path patch.cargo testcargo check --no-default-features --target wasm32-unknown-unknowncargo fmt --checkWhere this sits
Happy to rework any of it, and glad to split the clippy commit out if you would rather review the no_std work alone.